Skip to content

Conversation

@vzsoares
Copy link
Member

@vzsoares vzsoares commented Jun 7, 2022

Description

  • created testimonial card that consumes props
  • created dummy list with data

Notes

needs to be redered inside a grid (one was made at #131 )
needs real data ( in progress #128)

closes #127

Preview

chrome-capture-2022-5-7

@vzsoares vzsoares requested a review from a team June 7, 2022 22:09
@vzsoares vzsoares self-assigned this Jun 7, 2022
@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webapp ✅ Ready (Inspect) Visit Preview Jun 16, 2022 at 5:09PM (UTC)

@vzsoares vzsoares temporarily deployed to Firebase June 7, 2022 22:09 Inactive
@vzsoares vzsoares changed the title fea:create TestimonialCard Create TestimonialCard Jun 7, 2022
@vzsoares vzsoares temporarily deployed to Firebase June 7, 2022 22:15 Inactive
@vzsoares vzsoares temporarily deployed to Firebase June 8, 2022 20:06 Inactive
@vzsoares vzsoares force-pushed the vzsoares/create-TestimonialCard branch from b9defb0 to 81da991 Compare June 8, 2022 23:46
@vzsoares vzsoares temporarily deployed to Firebase June 8, 2022 23:46 Inactive
@vzsoares vzsoares temporarily deployed to Firebase June 15, 2022 01:21 Inactive
@vzsoares vzsoares force-pushed the vzsoares/create-TestimonialCard branch from ab786c9 to 46bcbc9 Compare June 16, 2022 01:50
@vzsoares vzsoares temporarily deployed to Firebase June 16, 2022 01:50 Inactive
@vzsoares vzsoares temporarily deployed to Firebase June 16, 2022 02:17 Inactive
@vzsoares vzsoares requested a review from marco-souza June 16, 2022 02:32
@vzsoares vzsoares temporarily deployed to Firebase June 16, 2022 02:32 Inactive
@vzsoares vzsoares temporarily deployed to Firebase June 16, 2022 17:08 Inactive
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booa Zenha ship it. 🚀 🚀 🚀

Código ficou limpinho, cheirozinho e bem isolado!

Uma dica para os próximos é evitar comandos destrutivos do git (git commit --amend, git rebase) até o fim do review.

Quanto rola algum comando destruitivo, o github se perde nas diferenças, e mostra todas as linhas como sendo alteradas desde o ultimo review.

Se você fizer apenas commits pra cada mudança ele vai mostrar as diferenças corretamente. Ai apos o approve você pode mandar o rebase na tranquilidade. 👍🏼

@vzsoares
Copy link
Member Author

Booa Zenha ship it. 🚀 🚀 🚀

Código ficou limpinho, cheirozinho e bem isolado!

Uma dica para os próximos é evitar comandos destrutivos do git (git commit --amend, git rebase) até o fim do review.

Quanto rola algum comando destruitivo, o github se perde nas diferenças, e mostra todas as linhas como sendo alteradas desde o ultimo review.

Se você fizer apenas commits pra cada mudança ele vai mostrar as diferenças corretamente. Ai apos o approve você pode mandar o rebase na tranquilidade. 👍🏼

dps podia rolar uma guide no notion msm pq ate consegui fazer mas fiquei meio perdido

@vzsoares vzsoares merged commit 5b84b47 into main Jun 18, 2022
@vzsoares vzsoares deleted the vzsoares/create-TestimonialCard branch June 18, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Criar card de testimonials

4 participants