Skip to content

Adiciona Footer na pagina #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melipefelgaco merged 19 commits into from
Sep 22, 2021
Merged

Adiciona Footer na pagina #40

melipefelgaco merged 19 commits into from
Sep 22, 2021

Conversation

@melipefelgaco
Copy link
Contributor

@melipefelgaco melipefelgaco commented Sep 16, 2021

Descrição

Adiciona um Footer na nossa pagina

Changes

Precisamos de um footer porem, por ora, nao precisamos/temos muita coisa pra colocar nele. Esse componente pode e deve ser expandido depois de obtermos as informacoes legais para colocar na pagina (como politica de privacidade e termos de servico)

Notes

Vejam que ambos os links de suporte apontam para o nosso maravilhoso abacate do 404. Estou tambem adicionando uma task na board para lidar com isso mas acho que por enquanto eh bom ter o link la. E aproveitar pra fazer uso do nosso 404 :)

@melipefelgaco melipefelgaco self-assigned this Sep 16, 2021
@melipefelgaco melipefelgaco added the feature New section component label Sep 16, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2021 •
edited
Loading

Visit the preview URL for this PR (updated for commit 12f2eae):

https://podcodar-webapp--pr40-fea-footer-6igrrgig.web.app

(expires Wed, 29 Sep 2021 17:21:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@marco-souza
Copy link
Contributor

marco-souza commented Sep 16, 2021

Ainda não revisei a fundo, mas reparei que vc removeu o container e não entendi bem. Do jeito que ta o rodape fica desalinhado

image

marco-souza
marco-souza requested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mano, da pra melhorar.

Acho que vc ta usando muita props que já é padrão. Recomendo antes de mandar a PR revisar e tentar remover props que não estão sendo aplicadas.

Alem disso, vamos tentar rerenderizar/recriar coisa desnecessárias. Sinto que falta um aprofundamento no entendimento do LifeCycle do React. Foca seus estudos nisso pois vai te salvar de varios problemas no futuro.

@melipefelgaco
Copy link
Contributor Author

melipefelgaco commented Sep 20, 2021 •
edited
Loading

fixed!

marco-souza
marco-souza requested changes Sep 20, 2021
View reviewed changes
@marco-souza
Copy link
Contributor

marco-souza commented Sep 20, 2021

Ou, não to achando esse Container full legal. Acho que ele tem que seguir o mesmo alinhamento de todas as outras sessões

@melipefelgaco
fix: resolve PR comments:
6f0d0fa 
- remove key from HeaderTitle
- delete FooterData
- change SimpleGrid to Section
- translate every hardcoded text
@melipefelgaco
Copy link
Contributor Author

melipefelgaco commented Sep 22, 2021

fixed

marco-souza
marco-souza reviewed Sep 22, 2021
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passou batido mas acho que só faltou aplicar a chaves de tradução para os social links

@melipefelgaco melipefelgaco merged commit 92f200b into main Sep 22, 2021
@melipefelgaco melipefelgaco deleted the fea/footer branch September 22, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-souza marco-souza marco-souza approved these changes

@frattezi frattezi Awaiting requested review from frattezi

@Joel-leal Joel-leal Awaiting requested review from Joel-leal

Assignees

@melipefelgaco melipefelgaco

Labels

feature New section component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@melipefelgaco @marco-souza