fix: emit errors on stream when .resolve method rejects#141
Merged
trygve-lie merged 2 commits intomasterfrom Oct 6, 2020
Merged
fix: emit errors on stream when .resolve method rejects#141trygve-lie merged 2 commits intomasterfrom
trygve-lie merged 2 commits intomasterfrom
Conversation
github-actions bot
pushed a commit
that referenced
this pull request
Oct 6, 2020
## [4.4.3](v4.4.2...v4.4.3) (2020-10-06) ### Bug Fixes * emit errors on stream when .resolve method rejects ([#141](#141)) ([9bc989b](9bc989b))
|
🎉 This PR is included in version 4.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 6, 2020
# [5.0.0-next.6](v5.0.0-next.5...v5.0.0-next.6) (2020-10-06) ### Bug Fixes * emit errors on stream when .resolve method rejects ([#141](#141)) ([9bc989b](9bc989b))
|
🎉 This PR is included in version 5.0.0-next.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.streammethod was not handling promise rejections from resource.resolve so if the resolve method rejected (eg. if resource was marked as throwable) then we got an unhandled promise rejection warning. This PR adds a catch and then just emits the error on the stream.