test: add failing unit test for structuredClone#289
Closed
Conversation
Contributor
Author
|
Maybe since |
wkillerud
added a commit
to podium-lib/client
that referenced
this pull request
Jul 1, 2025
This replacement with a shallow clone might look odd, but only one value at the root level is mutated. Also, because of a quirk with how clonedeep works with the AssetCss and AssetJs classes in podium utils, the entries in the css and js arrays weren't actually cloned – instead the values were copied. See podium-lib/utils#289 for a more thorough explanation with links to code.
wkillerud
added a commit
to podium-lib/client
that referenced
this pull request
Jul 1, 2025
This replacement with a shallow clone might look odd, but only one value at the root level is mutated. Also, because of a quirk with how clonedeep works with the AssetCss and AssetJs classes in podium utils, the entries in the css and js arrays weren't actually cloned – instead the values were copied. See podium-lib/utils#289 for a more thorough explanation with links to code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrating an issue that blocks us from adopting the native
structuredCloneas a replacement forlodash.clonedeepin client.This should work, but doesn't. The
cssandjsarrays become a list of empty objects.I think
cloneDeeponly works because it doesn't actualy clone the asset class instances.https://github.com/lodash/lodash/blob/ddfd9b11a0126db2302cb70ec9973b66baec0975/lodash.js#L2657
We hit this branch where it is an object, but not a clonable one, so it "clones" by returning the same instance. Confirmed with console log.
This on the line after cloning prints
trueacross all unit tests in client.