fix(toolcraft): bundle process-runner and ship transitive npm deps#283
Merged
fix(toolcraft): bundle process-runner and ship transitive npm deps#283
Conversation
toolcraft@0.0.12 crashed at module load because bundled @poe-code/task-list imported the private @poe-code/process-runner workspace package, which was neither in toolcraft's bundle nor on the public registry. Extending the cli smoke to import every entry point also surfaced jose, jsonc-parser, mustache, and smol-toml — transitive deps of bundled mcp-oauth and config-mutations that npm does not auto-install for bundled packages. - bundle @poe-code/process-runner alongside the other private workspace deps - declare jose, jsonc-parser, mustache, smol-toml as runtime deps so npm resolves them when consumers install toolcraft - exercise toolcraft/cli, /mcp, /mcp-proxy, /sdk in the standalone smoke - run smoke:toolcraft-standalone in the toolcraft release workflow before publishing so this regression cannot ship again Closes #282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolcraft@0.0.12crashed at module load because bundled@poe-code/task-listimported the private@poe-code/process-runnerworkspace package, which was neither in toolcraft's bundle nor on the public registry.jose,jsonc-parser,mustache,smol-toml) of bundledmcp-oauth/@poe-code/config-mutations— npm does not auto-install transitive deps for bundled packages.smoke:toolcraft-standalonebefore publishing so this kind of regression cannot ship.Test plan
npm run smoke:toolcraft-standalone— passes (failed before the fix onprocess-runner, then onjose)npm run test --workspace=toolcraft— 266 tests passnpm run lint --workspace=toolcraft— cleannpm run lint:workflows— clean🤖 Generated with Claude Code