Skip to content

fix SiteVisibility#57

Merged
SnosMe merged 3 commits into
poe-tool-dev:mainfrom
lvlvllvlvllvlvl:pr
Sep 8, 2023
Merged

fix SiteVisibility#57
SnosMe merged 3 commits into
poe-tool-dev:mainfrom
lvlvllvlvllvlvl:pr

Conversation

@lvlvllvlvllvlvl
Copy link
Copy Markdown
Collaborator

l made a mistake in the previous pr

@lvlvllvlvllvlvl
Copy link
Copy Markdown
Collaborator Author

Should l have not removed the enum? l assumed that an enum would always correspond to a dat file, and that if l couldn't find a dat file with that name it should be removed, but l guess that was a bad assumption.

@SnosMe
Copy link
Copy Markdown
Collaborator

SnosMe commented Sep 8, 2023

You should remove that enum, and keep it as i32. From the stream
image

https://youtu.be/XNN0RLIfg-Y?si=3t8JfHJRNTA1mpma&t=2689

Appereantly it was added by me 068c919
But yeah, I think we should not add theoretical non-exported enums (should also be easier for people tooling who don't expect custom enums, such as this issue 😄 )

@lvlvllvlvllvlvl
Copy link
Copy Markdown
Collaborator Author

done

@SnosMe SnosMe merged commit d9f609e into poe-tool-dev:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants