Skip to content

Print warning when passing an unknown type to list command#4

Merged
adi64 merged 1 commit intomainfrom
3-add-filter-warning
May 28, 2024
Merged

Print warning when passing an unknown type to list command#4
adi64 merged 1 commit intomainfrom
3-add-filter-warning

Conversation

@Floriszenz
Copy link
Copy Markdown
Collaborator

This PR improves the list command to print a warning message when passing an unknown category type as filter. The output will be:

$ npx picco ls --type=feature --type=unknown
┌   picco list
│
▲  Ignoring unknown category type "unknown"
│  Valid types are: "feature", "bugfix", "refactor", "performance", "dependencies", "removal", "migration", "documentation", "other"
│
●  Features
│  • Feature 1
│  • Feature 2
│
└   Have a nice day!

Closes #3

@Floriszenz Floriszenz self-assigned this May 27, 2024
print warning when passing an unknown category type
Copy link
Copy Markdown
Contributor

@adi64 adi64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 👍

@adi64 adi64 merged commit 6fdda15 into main May 28, 2024
@Floriszenz Floriszenz deleted the 3-add-filter-warning branch May 28, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List command: Type filter does not apply at all if passed type is unknown

2 participants