SQLite error 19: UNIQUE constraint failed in Reminders example preview mode

[jcmourey]

Description

seedSampleData() is called from appDatabase() when in preview mode.
Also, in preview mode: seedSampleData is called from the Seed Data Toolbar button
This causes SQLite to fail from attempting to add duplicate data.

Checklist

• I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
• I have determined whether this bug is also reproducible in a vanilla GRDB project.
• If possible, I've reproduced the issue using the main branch of this package.
• This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior

Not really a big deal, but since it is a demo project that should probably as clean as possible, seedSampleData should probably get called from one or the other place, not both.

Actual behavior

🟣 Reminders/RemindersLists.swift:146: Caught error: SQLite error 19: UNIQUE constraint failed: tags.title - while executing INSERT INTO "tags" ("title") VALUES (?), (?), (?), (?), (?), (?), (?)

Reproducing project

No response

SQLiteData version information

No response

Sharing version information

No response

GRDB version information

No response

Destination operating system

No response

Xcode version information

No response

Swift Compiler version information

[mbrandonw]

Hi @jcmourey, if you would like to fix this we would happily merge a PR. But we don't really consider this an issue so I am going to convert to a discussion.

One approach would be to explicitly invoke seedSampleData() in each preview and remove it from the appDatabase() function.

[jcmourey]

Or maybe the seedSampleData Toolbar button should be only available if the database is empty. That way, no need to clutter each #Preview with a call to seedSampleData(). It could still be called from appDatabase() in non .live mode.

What we lose is the ability to preview the Seed Sample Data toolbar button, but that could also be reintroduced with a single #Preview specially designed for that that would clear the data. I would be happy to propose a PR if that approach interests you.

[jcmourey]

Something funky going on with the preview (I haven't changed any code yet). The data has been seeded, and yet the seedSampleData tip is displayed and the seedSampleData menu is active. Something SwiftUI preview related maybe with the timing of things. I don't understand enough to mess with it for such a trivial problem.

[jcmourey]

I just figured out why. It's because even though the data has been seeded, reminderLists is empty because Preview doesn't create a syncEngine in prepareDependencies, and so FetchAll(RemindersList...) fails. And so no lists are displayed in the preview.

🟣 Sharing/Reference.swift:263: Caught error: SQLite error 1: no such table: sqlitedata_icloud_metadata - while executing SELECT count("reminders"."id") AS "remindersCount", "remindersLists"."id" AS "id", "remindersLists"."color" AS "color", "remindersLists"."position" AS "position", "remindersLists"."title" AS "title", "sqlitedata_icloud_metadata"."share" AS "share" FROM "remindersLists" LEFT JOIN "reminders" ON (("remindersLists"."id") = ("reminders"."remindersListID")) AND (NOT (("reminders"."status") <> (?))) LEFT JOIN "sqlitedata_icloud_metadata" ON ("remindersLists"."id", ?) = ("sqlitedata_icloud_metadata"."recordPrimaryKey", "sqlitedata_icloud_metadata"."recordType") GROUP BY "remindersLists"."id" ORDER BY "remindersLists"."position"