Relax sendability / improve default main actor isolation compatibility #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Nov 11, 2025
Comment on lines
+1237
to
+1248
| // func testConcurrency_SharedCasePath() async throws { | ||
| // enum Enum { case payload(Int) } | ||
| // nonisolated(unsafe) let casePath = /Enum.payload | ||
| // | ||
| // await withTaskGroup(of: Void.self) { group in | ||
| // for index in 1...maxIterations { | ||
| // group.addTask { | ||
| // XCTAssertEqual(casePath.extract(from: Enum.payload(index)), index) | ||
| // } | ||
| // } | ||
| // } | ||
| // } |
Member
Author
There was a problem hiding this comment.
This no longer compiles with the change, which is probably a good thing and fine given that we don't want to support the reflection-based syntax for much longer.
stephencelis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We learned some good lessons while developing the
@Tablemacro in StructuredQueries. Let's apply them here.This probably needs to be a 2.0 breaking change, and is incompatible with TCA 1.0 without some changes to TCA.