Correctly show (no state changes) in diff. #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
May 25, 2020
| let actionOutput = debugOutput(localAction).indent(by: 2) | ||
| let stateOutput = | ||
| debugDiff(previousState, nextState).map { "\($0)\n" } ?? " (No state changes)" | ||
| debugDiff(previousState, nextState).map { "\($0)\n" } ?? " (No state changes)\n" |
Member
Author
There was a problem hiding this comment.
this seemed to need a newline, found it while writing a test
mbrandonw
commented
May 25, 2020
| second.split(separator: "\n", omittingEmptySubsequences: false)[...] | ||
| ) | ||
| guard !differences.isEmpty else { return nil } | ||
| if differences.count == 1, case .both = differences[0].which { return nil } |
mbrandonw
commented
May 25, 2020
|
|
||
| func testPrint() { | ||
| struct Unit: Equatable {} | ||
| enum Action: Equatable { case incr, noop } |
Member
Author
There was a problem hiding this comment.
updated test for the "(no changes)" behavior
mbrandonw
changed the title
stephencelis
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found this while working off a feature branch, so just wanting to get it into master.