Print offending action on Store.send assertion #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
reviewed
Jun 16, 2020
Member
mbrandonw
left a comment
mbrandonw
left a comment
There was a problem hiding this comment.
I like it! I suggest one small change to simplify it a bit.
Thanks!
Co-authored-by: Brandon Williams <mbw234@gmail.com>
honghaoz
pushed a commit
to chouti-dev/swift-composable-architecture
that referenced
this pull request
Jul 6, 2020
* Print offending action on Store.send assertion * Reword Store.send assert Co-authored-by: Brandon Williams <mbw234@gmail.com> Co-authored-by: Brandon Williams <mbw234@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a debug print of an action sent recursively to the store. Useful if the stacktrace is long or Xcode does not show the action in the debug-tooltip (nothing to do with this library, but a bug that happens to me quite frequently).