Generic alerts and action sheets #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Jun 28, 2020
Examples/CaseStudies/SwiftUICaseStudies/01-GettingStarted-AlertsAndActionSheets.swift
Show resolved
Hide resolved
mbrandonw
commented
Jun 28, 2020
Examples/CaseStudies/SwiftUICaseStudies/01-GettingStarted-AlertsAndActionSheets.swift
Show resolved
Hide resolved
mbrandonw
commented
Jun 28, 2020
| format: | ||
| swift format --in-place --recursive ./Package.swift ./Sources ./Tests | ||
| swift format --in-place --recursive \ | ||
| ./Examples ./Package.swift ./Sources ./Tests |
Member
Author
There was a problem hiding this comment.
we weren't formatting ./Examples so I added that and it added some noise to this pr
mbrandonw
commented
Jun 30, 2020
Examples/CaseStudies/SwiftUICaseStudies/01-GettingStarted-SharedState.swift
Outdated
Show resolved
Hide resolved
* Use Optional to model generic alerts * Xcode 12 * Refinement * update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates some new generic state types that make it easy to work with alerts and action sheets in the TCA. The code is mostly straightforward, and has even cleaned up some code in our case studies, but I think a little more thought needs to be given to one part of the API.