Extend CoreImage conformance #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stephencelis
left a comment
stephencelis
left a comment
There was a problem hiding this comment.
Thanks for taking the time to PR! Some of the conformances should be good to go, but I'm bit quite sure I understand all of them...
Comment on lines
45
to
98
| extension CIContextOption: CustomDumpStringConvertible { | ||
| public var customDumpDescription: String { | ||
| switch self { | ||
| default: | ||
| return "CIContextOption.(default, rawValue: \(self.rawValue))" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension CIImageRepresentationOption: CustomDumpStringConvertible { | ||
| public var customDumpDescription: String { | ||
| switch self { | ||
| default: | ||
| return "CIImageRepresentationOption.(default, rawValue: \(self.rawValue))" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension CIFormat: CustomDumpStringConvertible { | ||
| public var customDumpDescription: String { | ||
| switch self { | ||
| default: | ||
| return "CIFormat.(default, rawValue: \(self.rawValue))" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension CIImageOption: CustomDumpStringConvertible { | ||
| public var customDumpDescription: String { | ||
| switch self { | ||
| default: | ||
| return "CIImageOption.(default, rawValue: \(self.rawValue))" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension CIImageAutoAdjustmentOption: CustomDumpStringConvertible { | ||
| public var customDumpDescription: String { | ||
| switch self { | ||
| default: | ||
| return "CIImageAutoAdjustmentOption.(default, rawValue: \(self.rawValue))" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension CIKernel: CustomDumpStringConvertible { | ||
| public var customDumpDescription: String { | ||
| switch self { | ||
| default: | ||
| return "CIKernel.(default, rawValue: \(self))" | ||
| } | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Should any of these conformances be necessary? None are switching on enum-like values, so I think the default rendering should be ok, right?
Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
Contributor
Author
|
I updated by removing the unnecessary conformance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extended some CoreImage conformance