Skip to content

Conversation

@davdroman
Copy link
Contributor

@davdroman davdroman commented Sep 21, 2021

Basically the same as #20 but for Linux this time. This PR fixes Swift 5.5 compilation on Linux.

Backstory: Swift 5.5 images don't come bundled with a version of Foundation containing AttributedString yet. Whilst the changes are in the upstream branch, a release hasn't been made yet — I believe because macOS 12 is not out yet and Apple wants parity with "Apple Foundation".

@stephencelis
Copy link
Member

@davdroman Bummer! But sounds like a good fix. I wonder if we should update Linux CI to work against Swift 5.5 (and maybe other versions, as well).

@davdroman
Copy link
Contributor Author

@stephencelis I'm happy to assist with that in this PR or a separate one (up to you). Docker images for Swift 5.5 are out now so it shouldn't be too complicated to do.

@stephencelis
Copy link
Member

@davdroman If you'd like to take a stab please do! It'd be cool to see the failure on that PR branch for what's being fixed on this one. We already have a Windows failure on main due to the order of merging PRs yesterday, ha, so the more robust our CI the better. We'll try to get around to fixing the Windows test failure tomorrow so that this PR can turn green.

@davdroman
Copy link
Contributor Author

@stephencelis here we go! #23

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, gonna merge this and see how the other PRs fare!

@stephencelis stephencelis merged commit 23801e4 into pointfreeco:main Sep 22, 2021
@davdroman davdroman deleted the fix-linux-build-errors branch September 22, 2021 02:51
stephencelis added a commit that referenced this pull request Sep 22, 2021
* CI: Enable Swift 5.5 Linux builds

* Update README.md

* Don't compile symbols for Linux that are not yet available (#22)

Co-authored-by: Stephen Celis <stephen@stephencelis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants