This repository was archived by the owner on May 14, 2021. It is now read-only.
COOK-3219: Using omnibus bundler for your app is bad#31
Merged
jtimberman merged 1 commit intopoise:masterfrom Jun 27, 2013
lamont-granquist:COOK-3219
Merged
COOK-3219: Using omnibus bundler for your app is bad#31jtimberman merged 1 commit intopoise:masterfrom lamont-granquist:COOK-3219
jtimberman merged 1 commit intopoise:masterfrom
lamont-granquist:COOK-3219
Conversation
Contributor
lamont-granquist
commented
Jun 21, 2013
lamont-granquist
commented
- default behavior is still unchanged
- allow user overriding env
- introduce "use_omnibus_ruby" true/false switch
- complain at people doing it wrong
- default behavior is still unchanged - allow user overriding env - introduce "use_omnibus_ruby" true/false switch - complain at people doing it wrong
Contributor
Author
|
This is one option to address the problem. This is the least intrusive to everyone's workflow, and should probably be temporarily put in to warn people that behavior will be changing in the future. I would be happy to make the default behavior to not use omnibus' ruby. We definitely need to get here. I would be extremely happy to simply revert COOK-744 with extreme prejudice and force people to hack up their environment manually if they really want their app to be tied to omnibus ruby... |
Contributor
There was a problem hiding this comment.
it seems these could be named with more clarity.
Contributor
There was a problem hiding this comment.
I believe this sets PATH to Gem.default_bindir and then the existing PATH, unless the user specifies a PATH.
jtimberman
pushed a commit
that referenced
this pull request
Jun 27, 2013
COOK-3219: Using omnibus bundler for your app is bad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.