Skip to content
This repository was archived by the owner on May 14, 2021. It is now read-only.

COOK-3367 Pass through more unicorn parameters#35

Merged
sethvargo merged 2 commits intopoise:masterfrom
bryanstearns:COOK-3367-more-unicorn-parameters
Aug 24, 2013
Merged

COOK-3367 Pass through more unicorn parameters#35
sethvargo merged 2 commits intopoise:masterfrom
bryanstearns:COOK-3367-more-unicorn-parameters

Conversation

@bryanstearns
Copy link
Copy Markdown
Contributor

There are several configuration parameters supported by the unicorn cookbook that aren't passed through by the rails subresource of the application_ruby cookbook: at the moment, I want to specify both before_fork (supported) and after_fork (not), but there are several other useful ones.

Note that this allows overriding of the entire 'listen' parameter if port isn't enough; all the rest are simple.

@christoph-buente
Copy link
Copy Markdown

Was about to implement it myself.

+1

@sethvargo
Copy link
Copy Markdown
Contributor

I'm 👍 on the code changes, but this needs a readme update to document these new attributes.

@bryanstearns
Copy link
Copy Markdown
Contributor Author

Good idea, sorry I missed that -- I'll add readme updates to the PR tonight. [Update: done!]

On Mon, Jul 22, 2013 at 12:41 PM, Seth Vargo notifications@github.comwrote:

I'm [image: 👍] on the code changes, but this needs a readme update to
document these new attributes.


Reply to this email directly or view it on GitHubhttps://github.com//pull/35#issuecomment-21370134
.

@cyu
Copy link
Copy Markdown

cyu commented Aug 14, 2013

What's the progress on this?

@jgarber
Copy link
Copy Markdown

jgarber commented Aug 21, 2013

👍

sethvargo pushed a commit that referenced this pull request Aug 24, 2013
…eters

COOK-3367 Pass through more unicorn parameters
@sethvargo sethvargo merged commit 3d0c3ff into poise:master Aug 24, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants