Fix version detection (setuptools and distribute)#94
Fix version detection (setuptools and distribute)#94coderanger merged 1 commit intomasterfrom unknown repository
Conversation
|
@coderanger We have been using this PR in our prod environment for a few weeks now, and can confirm that this has the desired behavior. This PR has my 👍 , thanks @mal! |
|
Leaving this open; but have forked the project to idio-cookbooks/python where this PR and any subsequent improvements will be maintained as master. |
|
@coderanger any interest in this or shall I shut it down? |
|
@mal Can you fix it to not use global variables? ( |
The versions of `distribute`, `pip`, `setuptools` and `wsgiref` are excluded from the output of `pip freeze`, however they do show up in the output from `pip list`. This allows us to use a more general implentation of parsing the output from `pip list` to get the current version of all distributions. Also removes a dependency on `grep`. Distributions excluded from `pip freeze`: /pypa/pip/blob/2ad8888901c041b8f9aacebb3a16d55bf631e867/pip/util.py#L372
|
@coderanger does that look about right? |
|
Taking your word that the behavior is correct, but looks good on the code :-) There are some experiments going on with multi-threaded Chef so might as well keep things clean. |
Fix version detection (setuptools and distribute)
|
Cool, ta |
3 participants
Fixes #81
The versions of
distribute,pip,setuptoolsandwsgirefare excluded from the output ofpip freeze, however they do show up in the output frompip list. This allows us to use a more general implentation of parsing the output frompip listto get the current version of all distributions.Also removes a dependency on
grep.Distributions excluded from
pip freeze:https://github.com/pypa/pip/blob/2ad8888901c041b8f9aacebb3a16d55bf631e867/pip/util.py#L372