Skip to content

Update peer activity every 30 seconds #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdubbelboer merged 2 commits into from
Oct 21, 2025
Merged

Update peer activity every 30 seconds #290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68025b5
Update peer activity every 30 seconds
erikdubbelboer Oct 20, 2025
d9a1feb
Merge branch 'main' into update-less
erikdubbelboer Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions internal/signaling/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import (

const LobbyCleanInterval = 30 * time.Minute
const LobbyCleanThreshold = 24 * time.Hour
const peerPingDuration = 2 * time.Second
const peerActiveUpdateInterval = 30 * time.Second

func Handler(ctx context.Context, store stores.Store, cloudflare *cloudflare.CredentialsClient) (*sync.WaitGroup, http.HandlerFunc) {
manager := &TimeoutManager{
Expand Down Expand Up @@ -82,9 +84,10 @@ func Handler(ctx context.Context, store stores.Store, cloudflare *cloudflare.Cre
}
}()

go func() { // Sending ping packet every 2 seconds to check if the tcp connection is still alive.
ticker := time.NewTicker(2 * time.Second)
go func() { // Sending ping packet every X to check if the tcp connection is still alive.
ticker := time.NewTicker(peerPingDuration)
defer ticker.Stop()
var lastActiveUpdate time.Time
for {
select {
case <-ticker.C:
Expand All @@ -100,7 +103,11 @@ func Handler(ctx context.Context, store stores.Store, cloudflare *cloudflare.Cre
// If we can send a ping packet, and the peer has an ID, we update the peer as being active.
// If the peer doesn't have an ID yet, it's still in the process of connecting, so we don't update it.
if peer.ID != "" {
manager.MarkPeerAsActive(ctx, peer.ID)
now := util.NowUTC(ctx)
if lastActiveUpdate.IsZero() || now.Sub(lastActiveUpdate) >= peerActiveUpdateInterval {
manager.MarkPeerAsActive(ctx, peer.ID)
lastActiveUpdate = now
}
}
}
case <-ctx.Done():
Expand Down