Skip to content

Fix golangci-lint and add as action #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdubbelboer merged 1 commit into from
Apr 29, 2026
Merged

Fix golangci-lint and add as action #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
pull_request:
push:
branches:
- main
- main

jobs:
test:
Expand All @@ -20,7 +20,19 @@
- run: yarn cucumber
env:
DOCKER_HOST: unix:///var/run/docker.sock
golangci-lint:
name: golangci-lint
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v6
with:
go-version: 1.26
- uses: actions/checkout@v6
- name: golangci-lint
uses: golangci/golangci-lint-action@v9
with:
version: v2.10.1
build:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
Expand All @@ -46,6 +58,7 @@
needs:
- build
- test
- golangci-lint
timeout-minutes: 30
if: github.ref == 'refs/heads/main'
steps:
Expand Down
7 changes: 0 additions & 7 deletions cmd/signaling/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package main

import (
"context"
"math/rand"
"net"
"net/http"
"os"
Expand Down Expand Up @@ -38,12 +37,6 @@ func main() {
return
}

if os.Getenv("ENV") == "local" || os.Getenv("ENV") == "test" {
rand.Seed(0)
} else {
rand.Seed(time.Now().UnixNano())
}

credentialsClient := cloudflare.NewCredentialsClient(
os.Getenv("CLOUDFLARE_APP_ID"),
os.Getenv("CLOUDFLARE_AUTH_KEY"),
Expand Down
4 changes: 2 additions & 2 deletions cmd/testproxy/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func main() {
_, lport, _ := net.SplitHostPort(conn.LocalAddr().String())
w.Write([]byte(lport)) //nolint:errcheck
go func() {
defer conn.Close()
defer conn.Close() // nolint:errcheck
buffer := make([]byte, 65_535)
var remote *net.UDPAddr
for {
Expand Down Expand Up @@ -93,7 +93,7 @@ func main() {
id := r.FormValue("id")
conn, ok := connections[id]
if ok {
conn.Close()
conn.Close() // nolint:errcheck
delete(connections, id)
}
})
Expand Down
Loading