Refactor from react to tailwindcss + basecoat#7
Merged
Conversation
- Remove Leaflet, Google Maps, and MapLibre map providers - Install and configure Tailwind CSS with @tailwindcss/vite plugin - Add Basecoat UI component library for buttons, inputs, etc. - Restructure analysis.html with new layout: - Header with hamburger menu (mobile) and gear icon command menu - Left sidebar (Waypoint Panel) that slides in on mobile - MapBox GL JS map filling remaining space - Replace Shoelace components with Basecoat equivalents - Remove theme switching functionality - Update event-panel.ts to use Tailwind utility classes - Create central styles.css with Tailwind and Basecoat imports - Update index.html landing page with Tailwind styling
Ensure altitude gradient stops have strictly ascending progress values by filtering out duplicates and enforcing a minimum increment between consecutive stops. This fixes the error: "Input/output pairs for 'interpolate' expressions must be arranged with input values in strictly ascending order."
- Add min-h-0 to main element to allow flex shrinking - Add min-h-0 min-w-0 to map container parent for proper flex behavior - Use explicit CSS positioning and dimensions for #map element - Add rules for mapboxgl canvas to ensure it fills the container
pokle
changed the title
Code reviewThis PR removes Shoelace web components and replaces them with Tailwind CSS and Basecoat UI, which violates the project's CLAUDE.md guidelines. The CLAUDE.md file explicitly requires:
This PR:
If this migration is intentional, the CLAUDE.md file should be updated as part of this PR to reflect the new UI framework standards. |
- CLAUDE.md: Replace Shoelace section with Tailwind CSS + Basecoat docs - Document setup, common components, and layout patterns - Update coding preferences to reference Basecoat/Tailwind - specs/igc-analysis-tool-spec.md: Update for MapBox-only architecture - Update map display section for MapBox GL JS - Update technical architecture file structure - Update dependencies list - specs/optimized-task-line-spec.md: Remove multi-provider references - Update map provider integration section for MapBox only - Add changelog entry for provider simplification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Map Providers
leaflet-provider.ts,google-provider.ts,maplibre-provider.ts, andmap-styles.tsmap-provider.tsto only support MapBoxmaplibre-gldependencyUI Framework
tailwindcss,@tailwindcss/vite, andbasecoat-csspackagesstyles.csswith Tailwind, Basecoat, and MapBox GL CSS importsbtn,input,alert, etc.)Layout Restructure
Bug Fixes
line-gradientinterpolation error by ensuring strictly ascending progress valuesTest plan