Fix build on Linux x86#168
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix RPM packaging failures on Linux x86_64 by preventing rpmbuild’s brp-strip step from attempting to strip non-native ELF binaries bundled as resources, which can abort the RPM build.
Changes:
- Patch
electron-installer-redhat’s generated spec file to set%global __strip /bin/true, disabling stripping during RPM build. - Add
readFile/writeFileusage to modify the generated spec before the installer runs, and restore the original method afterward.
Comment on lines
+105
to
+110
| const { Installer } = installer | ||
| const originalCreateSpec = Installer.prototype.createSpec | ||
| Installer.prototype.createSpec = async function (this: any) { | ||
| await originalCreateSpec.call(this) | ||
| const specContent: string = await readFile(this.specPath, 'utf8') | ||
| await writeFile(this.specPath, '%global __strip /bin/true\n' + specContent) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.