Skip to content

Conversation

@Voultapher
Copy link
Collaborator

Fixes: #25848

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 31, 2025
@Voultapher Voultapher force-pushed the implement-nulls-rolling-mean-by branch from d84a6a4 to 96d51c8 Compare December 31, 2025 15:24
@Voultapher
Copy link
Collaborator Author

Run curl -LsSf https://astral.sh/uv/install.sh | sh
curl: (56) The requested URL returned error: 504
Error: Process completed with exit code 56.

CI failure seems unrelated, didn't find the run again button.

)));
}
// start with a dummy index, will be overwritten on first iteration.
// SAFETY: FIXME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixme? Safety here is trivial as 0..0 is in-bounds for any array.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to rework Ag::new to just check to make it safe though, it's not called often.

@yonikremer
Copy link
Contributor

I fixed the issue that causes the tests to fail, update your branch an rerun the github actions and the tests should pass

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 52.12766% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.50%. Comparing base (fcf909e) to head (abdb381).

Files with missing lines Patch % Lines
...unkedarray/rolling_window/rolling_kernels/nulls.rs 39.53% 78 Missing ⚠️
...s-time/src/chunkedarray/rolling_window/dispatch.rs 79.66% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25917      +/-   ##
==========================================
- Coverage   80.51%   80.50%   -0.02%     
==========================================
  Files        1771     1772       +1     
  Lines      243271   243422     +151     
  Branches     3037     3037              
==========================================
+ Hits       195875   195955      +80     
- Misses      46614    46685      +71     
  Partials      782      782              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Null Support for rolling operations (e.g. rolling_xyz_by)

3 participants