chore: Clean up error handling around Hub client requests #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstlaurent
requested review from
Andrewq11,
achchala,
mercuryseries and
roselynh100
jstlaurent
force-pushed
the
chore/error-handling-cleanup
branch
from
d146221 to
c682c98
Compare
mercuryseries
approved these changes
Jan 23, 2025
Contributor
mercuryseries
left a comment
mercuryseries
left a comment
There was a problem hiding this comment.
Thanks, @jstlaurent 💅!
jstlaurent
force-pushed
the
chore/error-handling-cleanup
branch
from
86b9c97 to
39f39c3
Compare
cwognum
approved these changes
Jan 23, 2025
Collaborator
cwognum
left a comment
cwognum
left a comment
There was a problem hiding this comment.
Thank you, @jstlaurent !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs
PolarisHubError, to have more helpful messagesChecklist:
Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).feature,fix,chore,documentationortest(or ask a maintainer to do it for you).I noticed that we had some type incompatibilities when instanciating
PolarisHubError, around the response object passed in. I corrected this, and took the opportunity to simplify and straightenup the error handling around the client's requests to the Hub. It should now do a better job at surfacing
PolarisHubError, which have nicer user facing messages than the underlying errors.