-
Notifications
You must be signed in to change notification settings - Fork 10
refactor/chore: Removing dataset/benchmark upload functions from Python client #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hub' functions from Python client
…hmark upload function removals
j279li
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
jstlaurent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one comment, about some last minute changes to the package. Otherwise, looks good!
Andrewq11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @danielpeng1! Left one comment about the deprecation warning.
…recatedError for client.py upload_to_hub functions
jstlaurent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changelogs
This PR removes the ability to upload datasets and benchmarks directly from the Python client.
upload_to_hubfunctions inclient.pyto raise aPolarisDeprecationError.upload_to_hubfunctions.Outdated
polaris/hub/client.py:upload_datasetmethod_upload_v1_datasethelper method_upload_v2_datasethelper methodupload_benchmarkmethod_upload_v1_benchmarkhelper method_upload_v2_benchmarkhelper methodpolaris/dataset/_base.py:upload_to_hubChecklist:
feature,fix,chore,documentationortest(or ask a maintainer to do it for you).