Skip to content

Conversation

@danielpeng1
Copy link
Contributor

@danielpeng1 danielpeng1 commented May 13, 2025

Changelogs

This PR removes the ability to upload datasets and benchmarks directly from the Python client.

  • Changed upload_to_hub functions in client.py to raise a PolarisDeprecationError.
  • Kept artifact-specific upload_to_hub functions.
  • Removed documentation regarding dataset/benchmark upload functionality.
Outdated
  • Removed from polaris/hub/client.py:
    • upload_dataset method
    • _upload_v1_dataset helper method
    • _upload_v2_dataset helper method
    • upload_benchmark method
    • _upload_v1_benchmark helper method
    • _upload_v2_benchmark helper method
  • Removed from polaris/dataset/_base.py:
    • Abstract method declaration for upload_to_hub
  • Removed documentation regarding dataset/benchmark upload functionality.
---

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

@danielpeng1 danielpeng1 self-assigned this May 13, 2025
@danielpeng1 danielpeng1 requested a review from cwognum as a code owner May 13, 2025 14:41
@danielpeng1 danielpeng1 added documentation Improvements or additions to documentation chore labels May 13, 2025
Copy link
Contributor

@j279li j279li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@jstlaurent jstlaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one comment, about some last minute changes to the package. Otherwise, looks good!

Copy link
Contributor

@Andrewq11 Andrewq11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @danielpeng1! Left one comment about the deprecation warning.

Copy link
Contributor

@jstlaurent jstlaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielpeng1 danielpeng1 merged commit 4c3ab4e into main May 15, 2025
19 checks passed
@jstlaurent jstlaurent deleted the refactor/upload-functions-removal branch May 16, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants