-
Notifications
You must be signed in to change notification settings - Fork 10
Refactor/public bucket access #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tests right now are failing because the Hub hasn't been updated yet (as the client isn't sending authentication tokens anymore). |
Andrewq11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @j279li! A lot of good work here. I've left some comments related to suggestions and clarifications that we should cover.
Also, I've requested the wisdom of @jstlaurent on some storage action organization.
jstlaurent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few questions and suggestions. 😄
Andrewq11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a few small comments. Looks good on my side after those.
Refactors the Polaris Hub client and storage modules to simplify authentication handling and allow for public access of artifacts. Key changes include removing authentication for reads, and updating dataset and benchmark retrieval methods to get data path from the API response.
Authentication and Session Management Updates:
PolarisHubClientand added explicit token validation where necessary, such as inupload_resultsandupload_model.modeparameter inStorageSessionto control authentication requirements, making it optional for read operations but mandatory for write operations.Dataset and Benchmark Handling Improvements:
_base_request_to_hubwithrequestand using metadata fields (zarr_path,table_path) for loading resources.Storage Refactor:
StorageSessionwithfsspecfor handling get file and store operations.Codebase Simplification: