Skip to content

Fix issues due to the string representation of the HubOwner #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2023
Merged

Fix issues due to the string representation of the HubOwner #59

merged 3 commits into from
Nov 23, 2023

Conversation

@cwognum
Copy link
Collaborator

@cwognum cwognum commented Nov 23, 2023 •
edited
Loading

Changelogs

  • Add the __str__() method to HubOwner to fix an issue where the computed artifact ID wasn't correct.
  • Properly slugify the artifact ids when uploading to Hub.

Discussion

This was encountered by @zhu0619 and during a user test with @FNTwin. A bug otherwise occurs at:

@cwognum cwognum added the fix Annotates any PR that fixes bugs label Nov 23, 2023
@cwognum cwognum requested a review from hadim as a code owner November 23, 2023 20:49
@cwognum cwognum merged commit 03d64ff into main Nov 23, 2023
@cwognum cwognum deleted the fix/artifact-id branch November 23, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hadim hadim hadim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix Annotates any PR that fixes bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cwognum @hadim