Skip to content

Conversation

@cwognum
Copy link
Collaborator

@cwognum cwognum commented Mar 20, 2024

Changelogs

  • Added the verify_checksum parameter to load_dataset and load_benchmark.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

#77 changed how the checksum is computed, which created errors when loading a dataset or benchmark from the hub. More generally, I think the checksum can be a little brittle so having a way to disable it seems good.

@cwognum cwognum added the fix Annotates any PR that fixes bugs label Mar 20, 2024
@cwognum cwognum self-assigned this Mar 20, 2024
@cwognum cwognum merged commit 79b5d4e into main Mar 20, 2024
@cwognum cwognum deleted the feat/disable-checksum branch March 20, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Annotates any PR that fixes bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants