clients/packages/ui: fix double scrollbar#5191
Merged
frankie567 merged 1 commit intopolarsource:mainfrom Apr 11, 2025
Merged
Conversation
|
@qwtel is attempting to deploy a commit to the polar-sh Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
Thank you for the fix @qwtel 🙏 I tweaked it a bit so it doesn't break scrolling on mobile, but otherwise, really nice catch 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes double scrollbars. The outer scrollbar is unnecessary. Currently it always overflows by
.5rem(caused by padding-top of the child). As best as I can tell there's never a reason to overflow the outermost wrapper, so fixed via clipping.