Skip to content

Conversation

@SteveNguyen
Copy link
Contributor

No description provided.

@SteveNguyen SteveNguyen requested a review from askuric April 1, 2025 17:01
@SteveNguyen SteveNguyen linked an issue Apr 1, 2025 that may be closed by this pull request
@askuric askuric changed the base branch from develop to 86-propagate-set_target_velocity-and-set_target_torque April 1, 2025 18:05
@askuric
Copy link
Contributor

askuric commented Apr 1, 2025

It looks good to me, but I cannot really test it. :D

Will this HWI modification allow setting the torque, velocity and position target values separately?

At the moment we had the position control pass through the JointCommands topic, but the velocity and torque commands were 0.

Will the target velocity and target torque be separate messages or will they be within the JointCommands too?
In practice it would be better that they are not, as the torque target will be used as feed-forward for the gravity compensation.

Ideally, all the target values (pos, vel and torque) would be in JointCommands (and we would use only one of them given the current mode of opertaion), but we would have another interface for the feed-forward terms.
And ideally, we would have another set of entries in the EtherCAT communication that would correspond to the feed-forward terms.

@SteveNguyen SteveNguyen merged commit df5126e into 86-propagate-set_target_velocity-and-set_target_torque Apr 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

torque current conversion

3 participants