Unexpected clicking at note on

[polluxsynth]

Sometimes there is an unexpected click or thump at note on.

For instance, load up the Bowed Strings preset, and play a few notes. Then change to the Default preset, which is just silence, and play a few notes. Note how there is some soft clicking on some notes the first time the voice is trigged, but once the voice has played the patch once, it is silent as expected.

On some patches, it can be for every new note which is annoying. (Will post specific patches when I find them).

One theory is that when a voice is cut off in economy mode because the loudness release phase runs out, there is still some audio in the delay lines which have not yet been played, and when the voice is retriggered and the DSP resumed, the tail end of the previous incarnation is heard as the delay lines are reanimated. If this is so, then the voice should not be shut off until a number of samples after the loudness release phase has completed.

[polluxsynth]

Tried to add drain state to envelopes to allow them to run after release phase has ended (branch fix-note-on-click).
However, this didn't make a difference, so the new theory is that when the DSP is stopped, if there is any resonance
on the filter in the old patch but not in the new, it will take time for the filter oscillations to cease when the voice is started up again.