Conversation
…assword login Agent-Logs-Url: https://github.com/poly-workshop/identra/sessions/d94f1895-65a0-46b5-aef5-90c7960533a5 Co-authored-by: slhmy <31381093+slhmy@users.noreply.github.com>
Agent-Logs-Url: https://github.com/poly-workshop/identra/sessions/d94f1895-65a0-46b5-aef5-90c7960533a5 Co-authored-by: slhmy <31381093+slhmy@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
slhmy
April 15, 2026 06:53
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SendLoginEmailCode,LoginByEmailCode, andLoginByPasswordhad no protection against abuse — unlimited send attempts and no lockout on repeated credential failures.Changes
cache.RateLimiter(newredis_rate_limiter.go)Redis-backed interface using Lua scripts for atomicity:
IsAllowed(ctx, key)— read-only check (no side effects)Record(ctx, key)— increment failure counter; sets TTL on first callReset(ctx, key)— clear counter on successful authConfig (
config.go)New fields with sensible defaults:
LoginMaxAttemptsLoginLockoutDurationSendCodeMaxAttemptsSendCodeWindowService (
service.go)loginRateLimiterapplied toLoginByPasswordandLoginByEmailCode: check before attempt →Recordon failure →Reseton successsendCodeRateLimiterapplied toSendLoginEmailCode: check +Recordbefore sendingmailerfield widened from*smtp.Mailertomail.Senderinterface (already existed in the codebase) to enable the new unit testsTests (
service_rate_limit_test.go)9 unit tests covering block-on-exceeded, record-on-failure, and reset-on-success for all three endpoints, using in-memory mocks (no Redis required).