Skip to content

feat: add poly branch delete command#63

Merged
oeisenberg merged 17 commits intomainfrom
feat/branch-delete
Apr 8, 2026
Merged

feat: add poly branch delete command#63
oeisenberg merged 17 commits intomainfrom
feat/branch-delete

Conversation

@oeisenberg
Copy link
Copy Markdown
Contributor

@oeisenberg oeisenberg commented Apr 2, 2026 •
edited
Loading

Summary

Adds poly branch delete — an interactive command for deleting branches, following the same UX pattern as poly review delete.

Motivation

Branch deletion was already implemented in the backend (project.delete_branch()) but not exposed through the CLI.

Changes

  • Added delete subcommand to poly branch with optional branch_name argument
  • Interactive checkbox selection (via questionary) when no branch name is provided
  • Direct deletion mode when branch name is passed as argument
  • JSON output mode support (--json)
  • Filters out main branch (cannot be deleted)
  • 16 new unit tests covering all code paths

Test strategy

  • Added/updated unit tests
  • Manual CLI testing (poly <command>)
  • Tested against a live Agent Studio project
  • N/A (docs, config, or trivial change)
image image image

Checklist

  • ruff check . and ruff format --check . pass
  • pytest passes (431 tests)
  • No breaking changes to the poly CLI interface (or migration path documented)
  • Commit messages follow conventional commits

🤖 Generated with Claude Code

@oeisenberg @claude
feat: add poly branch delete command with interactive selection
822c5b3 
Mirrors the style of `poly review delete` — supports direct deletion via
branch name argument or interactive checkbox selection for bulk deletion.
Includes JSON output mode and full error handling.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg @claude
fix: check branch names not IDs in delete_branch validation
ec74281 
`get_branches()` returns `{name: id}` — the existence check was against
`.values()` (IDs) instead of keys (names), so deletion always raised
"does not exist".

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg @claude
fix: suppress verbose HTML error on branch delete failure
6630558 
Downgrade `logger.error` to `logger.debug` in `delete_branch` so the
full API error body (HTML) is only shown with `--verbose`, matching the
pattern from 8e54b2d.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg @claude
fix: show clean error code on branch delete failure instead of HTML dump
747d27f 
- SDK: use `str(e)` (e.g. "404 Client Error: Not Found for url: ...")
  instead of `e.response.text` (raw HTML) when response isn't JSON
- sync_client: re-raise SourcererAPIError so the CLI can display it
- project: simplify delete_branch now that errors propagate via exception

Output now matches `poly review` style:
  Error: API request failed: 404 Client Error: Not Found for url: ...

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg @claude
feat: add tab auto-complete and confirmation prompt for branch delete
20b1faf 
- Add argcomplete completer for `poly branch delete <TAB>` that lists
  deletable branch names from the project
- Add `questionary.confirm` step before deleting in both direct and
  interactive modes (skipped in --json mode)
- Update tests to mock the new confirmation prompt

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg @claude
fix: clean up branch name completer docstring
a308f6e 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg @claude
fix: match argcomplete completer signature to prevent silent failure
33db9da 
argcomplete calls completers with (prefix, action, parser, parsed_args)
but our completer only accepted (prefix, parsed_args) — the mismatch
caused a silent crash that fell back to file completion.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg @claude
fix: fix branch delete sequence fetch and tab completion setup
8553d7d 
- Fix delete_branch to fetch sequence from branch projection endpoint
  instead of the /sequence endpoint which 404s on the ADK API
- Fix tab completer to use read_project_config (supports parent dir
  traversal) instead of the raw dataclass constructor which always failed
- Fix `poly completion zsh` crash caused by missing verbose attribute
  on the completion subparser
- Suppress option flags from polluting branch name completions

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg oeisenberg requested a review from Ruari-Phipps April 2, 2026 15:57
@oeisenberg

This comment was marked as outdated.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg oeisenberg requested a review from alanacevedo April 7, 2026 11:43
oeisenberg
oeisenberg commented Apr 7, 2026
View reviewed changes
Comment thread src/poly/cli.py
Ruari-Phipps
Ruari-Phipps reviewed Apr 7, 2026
View reviewed changes
Comment thread src/poly/handlers/sdk.py Outdated
Ruari-Phipps
Ruari-Phipps reviewed Apr 7, 2026
View reviewed changes
Comment thread src/poly/handlers/sdk.py
Ruari-Phipps
Ruari-Phipps reviewed Apr 7, 2026
View reviewed changes
Comment thread src/poly/cli.py
Ruari-Phipps
Ruari-Phipps reviewed Apr 7, 2026
View reviewed changes
Comment thread src/poly/project.py Outdated
Ruari-Phipps
Ruari-Phipps reviewed Apr 7, 2026
View reviewed changes
Comment thread src/poly/cli.py
Ruari-Phipps
Ruari-Phipps reviewed Apr 7, 2026
View reviewed changes
Comment thread src/poly/cli.py
oeisenberg and others added 2 commits April 7, 2026 17:34
@oeisenberg @Ruari-Phipps
Update src/poly/cli.py
29f7d51 
Co-authored-by: Ruari Phipps <ruari@poly-ai.com>
@oeisenberg
chore: Fix Test
bcf5486
@github-actions

This comment has been minimized.

Sign in to view
Ruari-Phipps
Ruari-Phipps reviewed Apr 7, 2026
View reviewed changes
Comment thread src/poly/cli.py
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@oeisenberg oeisenberg requested a review from Ruari-Phipps April 8, 2026 09:51
@oeisenberg
test: Update test
2d717a8
@oeisenberg
fix: Update --json logic to when detecting if the current branch wa…
e357a4a 
…s deleted

When deleting multple branches with `--json` it was possible to incorrectly emit `switched_to: "main"`.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Coverage Report

Base (main) PR Change
71.5% 71.5% +0.1% ✅

Changed file coverage

File Coverage Change
poly/handlers/sdk.py 14.3% -0.2% ⚠️
poly/cli.py 43.7% +4.0% ✅

@oeisenberg oeisenberg merged commit 463a663 into main Apr 8, 2026
3 checks passed
@oeisenberg oeisenberg deleted the feat/branch-delete branch April 8, 2026 13:25
@AaronForinton AaronForinton mentioned this pull request Apr 10, 2026
Merged
8 tasks
AaronForinton added a commit that referenced this pull request Apr 10, 2026
@AaronForinton @github-actions
docs: feat: add poly branch delete command (#67)
285327b 
## Summary

This PR is related to #63

## Motivation

<!-- Why is this change needed? Link to an issue if applicable. -->

Closes #<!-- issue number -->

## Changes

<!-- Bullet list of the key changes. Focus on *what* changed, not *how*.
-->

-

## Test strategy

<!-- How did you verify this works? Check all that apply. -->

- [ ] Added/updated unit tests
- [ ] Manual CLI testing (`poly <command>`)
- [ ] Tested against a live Agent Studio project
- [ ] N/A (docs, config, or trivial change)

## Checklist

- [ ] `ruff check .` and `ruff format --check .` pass
- [ ] `pytest` passes
- [ ] No breaking changes to the `poly` CLI interface (or migration path
documented)
- [ ] Commit messages follow [conventional
commits](https://www.conventionalcommits.org/)

## Screenshots / Logs

<!-- Optional: paste terminal output, screenshots, or before/after diffs
if helpful. -->

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ruari-Phipps Ruari-Phipps Ruari-Phipps approved these changes

@alanacevedo alanacevedo Awaiting requested review from alanacevedo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oeisenberg @Ruari-Phipps