Skip to content

fix: Don't show diff for reordered entities#87

Merged
Ruari-Phipps merged 1 commit intomainfrom
ruari/fix/allow_any_entity_order
Apr 17, 2026
Merged

fix: Don't show diff for reordered entities#87
Ruari-Phipps merged 1 commit intomainfrom
ruari/fix/allow_any_entity_order

Conversation

@Ruari-Phipps
Copy link
Copy Markdown
Collaborator

Summary

Fix spurious diffs after push caused by extracted_entities list ordering differences between local YAML and the platform.

Motivation

After pushing, poly diff shows reordering-only changes to extracted_entities in flow steps. The platform returns entity IDs in a different order than local YAML, producing false diffs with no meaningful content change.

Changes

  • Sort extracted_entities in FlowStep.to_yaml_dict() so both local and remote representations use a consistent alphabetical order

Test strategy

  • Added/updated unit tests
  • Manual CLI testing (poly <command>)
  • Tested against a live Agent Studio project
  • N/A (docs, config, or trivial change)

Checklist

  • ruff check . and ruff format --check . pass
  • pytest passes
  • No breaking changes to the poly CLI interface (or migration path documented)
  • Commit messages follow conventional commits

Screenshots / Logs

@Ruari-Phipps Ruari-Phipps requested a review from a team April 17, 2026 14:22
@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Base (main) PR Change
71.8% 71.8% +0.0% ✅

@Ruari-Phipps Ruari-Phipps merged commit 2a0ff85 into main Apr 17, 2026
3 checks passed
@Ruari-Phipps Ruari-Phipps deleted the ruari/fix/allow_any_entity_order branch April 17, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants