Skip to content

Made specification duplicates validation case insensitive so that "io… #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gastonortiz merged 1 commit into from
Feb 21, 2024
Merged

Made specification duplicates validation case insensitive so that "io… #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Java Client Library (beta)
### v0.3.4
### v0.3.5

## Introduction
Welcome my friends! This is the Poly API Java client GitHub page. If you are here, then it means you're familiar with what we do at Poly. If you aren't, you can always check [here](https://github.com/polyapi/poly-alpha).
Expand Down Expand Up @@ -347,6 +347,8 @@ Comparing to its Typescript counterpart, the Java library is still missing the f
These features will be added in the future releases.

## Changelog
### v0.3.5
- Made specification duplicates validation case insensitive so that 'io.polyapi.FunctionName' would be a duplicate of 'io.polyapi.Functionname'.
### v0.3.4
- Added validation to avoid duplicate specifications based on context and name.
### v0.3.3
Expand Down
2 changes: 1 addition & 1 deletion polyapi-maven-plugin/src/main/java/io/polyapi/plugin/service/SpecificationServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public List<Specification> getJsonSpecs() {
logger.debug("Validating for duplicate context/name pairs.");
Map<String, Specification> uniquenessValidationMap = new HashMap<>();
specifications.forEach(specification -> {
String key = format("%s.%s", specification.getContext(), specification.getName());
String key = format("%s.%s", specification.getContext(), specification.getName()).toLowerCase();
if (uniquenessValidationMap.containsKey(key)) {
logger.warn("Skipping {} specification '{}' in context '{}' as it clashes with {} specification with the same name and context.", specification.getType(), specification.getName(), specification.getContext(), uniquenessValidationMap.get(key).getType());
} else {
Expand Down