Skip to content

Resolve daemon warnings for threading methods#56

Merged
md-mq merged 1 commit intopolyaxon:masterfrom
emmanuel-ferdman:master
May 10, 2025
Merged

Resolve daemon warnings for threading methods#56
md-mq merged 1 commit intopolyaxon:masterfrom
emmanuel-ferdman:master

Conversation

@emmanuel-ferdman
Copy link
Copy Markdown
Contributor

PR Summary

This small PR resolve the deprecation warnings of daemon for threading methods:

/home/runner/work/polyaxon/polyaxon/cli/cli/polyaxon/_client/workers/base_worker.py:34: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@md-mq
Copy link
Copy Markdown
Contributor

md-mq commented May 10, 2025

We are still supporting some older versions of python, so we can't merge this yet.

@emmanuel-ferdman
Copy link
Copy Markdown
Contributor Author

emmanuel-ferdman commented May 10, 2025

@mmourafiq I believe the change from setDaemon(True) to directly setting the daemon property (thread.daemon = True) was introduced in Python 2.6. Does the project still support Python 2.5 and earlier? See more information here. Looking into the setup.py file, It looks like the minimum Python version supported by this polyaxon/cli is Python 3.8.

Copy link
Copy Markdown
Contributor

@md-mq md-mq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct 👍

@md-mq md-mq merged commit 57334c0 into polyaxon:master May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants