Merged
Conversation
List autocompletion was partially broken because a look up with the wrong key name was done. This commit also adds some logic to avoid suggesting the "add", "del", "show" commands when in the middle of a list completion. ex: polycubectl cube_name complex_list key1 <tab>: suggest list of key2 for elements that also matchs key1. Fixes: 95aa741 ("implement bash autocompletion") Signed-off-by: Mauricio Vasquez B <mauriciovasquezbernal@gmail.com>
frisso
approved these changes
Apr 12, 2019
mbertrone
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List autocompletion was partially broken because a look up with the wrong key
name was done.
This commit also adds some logic to avoid suggesting the "add", "del", "show"
commands when in the middle of a list completion. ex:
polycubectl cube_name complex_list key1 : suggest list of key2 for
elements that also matchs key1.