polycubed: set missing default elements only at initialization time#116
Merged
polycubed: set missing default elements only at initialization time#116
Conversation
polycubed fills the default elements on a request if they are missing, this guarantees that the default elements are always set when the request arrives to the service implementation, hence the developer has not to take care of it. When an update (PATCH) request is done those fields should not be set, because their value will be modified even if the client wanted to update other elements. Fixes: d8d280c ("Added new REST API and validation code") Reported-by: Elis Lulja <elis.lulja@gmail.com> Signed-off-by: Mauricio Vasquez B <mauriciovasquezbernal@gmail.com>
mauriciovasquezbernal
force-pushed
the
pr/fix_set_missing_default
branch
from
c590168 to
d200165
Compare
frisso
approved these changes
Apr 26, 2019
mbertrone
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polycubed fills the default elements on a request if they are missing, this
guarantees that the default elements are always set when the request arrives to
the service implementation, hence the developer has not to take care of it.
When an update (PATCH) request is done those fields should not be set, because
their value will be modified even if the client wanted to update other elements.