tests: check for services to be loaded before starting test#127
Merged
tests: check for services to be loaded before starting test#127
Conversation
mbertrone
force-pushed
the
pr/fix_tests_wait_service
branch
from
4d59934 to
9adc4ac
Compare
this commit introduces support for checking services to be loaded before start the tests. Signed-off-by: Matteo Bertrone <m.bertrone@gmail.com>
Signed-off-by: Matteo Bertrone <m.bertrone@gmail.com>
this commit wants to avoid code duplication between testing scripts Signed-off-by: Matteo Bertrone <m.bertrone@gmail.com>
mbertrone
force-pushed
the
pr/fix_tests_wait_service
branch
from
d08c8a3 to
46d164a
Compare
frisso
approved these changes
May 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces support for checking services to be
loaded before starting the tests.
From d8d280c commit "Added new REST API and validation code", rest server is started [1] before services are loaded.
This introduces the possibility services are not yet loaded when polycubed is up and responsive and can cause tests to fail.
[1] https://github.com/polycube-network/polycube/blob/master/src/polycubed/src/polycubed.cpp#L276