Conversation
frisso
approved these changes
May 31, 2019
| uint16_t dst_port; | ||
| uint8_t proto; | ||
| }; | ||
| } __attribute__((packed)); |
Contributor
There was a problem hiding this comment.
Matteo, can you please add a brief comment in the code stating why this attribute is needed?
E.g. /* attribute packet forces alignment for this structure; otherwise segmentation fault may happen when the userspace component tries to get access to that above data */
Contributor
Author
There was a problem hiding this comment.
Sure, comments added.
mbertrone
force-pushed
the
pr/fix_nat_session_table
branch
from
cf5b2c5 to
a5232a8
Compare
Contributor
Author
|
@mauriciovasquezbernal could you please check the machine is building docker images? |
ensure st_k and st_v structs are aligned Signed-off-by: Matteo Bertrone <m.bertrone@gmail.com>
mauriciovasquezbernal
force-pushed
the
pr/fix_nat_session_table
branch
from
a5232a8 to
9a75f00
Compare
mauriciovasquezbernal
approved these changes
Jun 4, 2019
Contributor
There was a problem hiding this comment.
I tested it and it works fine.
@mbertrone I confirm there were some problems with the machine we use to build the docker image, I rebase to master and force pushed this branch, it should work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure st_k and st_v structs are aligned, using
__attribute__((packed)).