link to affected 3rd party test runners in docstring#426
Merged
tengstrand merged 1 commit intopolyfy:masterfrom Jan 26, 2024
Merged
link to affected 3rd party test runners in docstring#426tengstrand merged 1 commit intopolyfy:masterfrom
tengstrand merged 1 commit intopolyfy:masterfrom
Conversation
Signed-off-by: Sean Corfield <sean@corfield.org>
Contributor
|
@seancorfield thanks for documenting this. Do you think it would be worth making the contract explicit? If yes, have you got any suggestions on a way to do that? |
Contributor
Author
|
Specs for the arguments that cover the required keys and an For now, just a great big reminder in the docstring is probably enough :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Corfield sean@corfield.org