Add HttpRequest and HttpResponse msg types #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename HttpRawRequest/HttpRawResponse to HttpRequest/HttpResponse - Add detailed field documentation following polymath_msgs conventions - Remove misleading "logging" designation
jon-mcmillan
changed the title
Contributor
Author
|
Dropped the Raw modifier and added comments to the fields. |
troygibb
approved these changes
Jul 28, 2025
| # HTTP request message | ||
|
|
||
| # Standard ROS header | ||
| std_msgs/Header header |
Contributor
There was a problem hiding this comment.
one thing internally we need to follow up on is whether we want to align on using headers in our message definitions or just a timestamp. I'm starting to lean towards the latter, but this is fine for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds new ROS message types to capture HTTP request and response data for logging and diagnostics of REST API bridge comms.
Changes
HttpRequest.msgfor incoming HTTP request details including method, path, headers, and bodyHttpResponse.msgfor HTTP response data including status code, headers, body, and response duration