Detecting direct access to base class state (4th defect type) #48
Merged
nikololiahim merged 20 commits intomasterfrom May 15, 2022
Merged
Detecting direct access to base class state (4th defect type) #48nikololiahim merged 20 commits intomasterfrom
nikololiahim merged 20 commits intomasterfrom
Conversation
fizruk
previously approved these changes
Apr 4, 2022
Member
|
Please, add example(s) with explanation to the description of the PR. |
nikololiahim
previously approved these changes
Apr 4, 2022
…lystat/odin into direct_access_to_state_defect
690cacc to
3722747
Compare
nikololiahim
previously approved these changes
May 15, 2022
nikololiahim
approved these changes
May 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Example of the defect
The proper way to change the state in the subclass
bwould be:An improper way to achieve the same functionality in subclass
bad:More detailed information about the problem statement and implementation is available here.