Detecting Liskov substitution principle violation (5th defect type)#51
Merged
nikololiahim merged 28 commits intomasterfrom May 15, 2022
Merged
Detecting Liskov substitution principle violation (5th defect type)#51nikololiahim merged 28 commits intomasterfrom
nikololiahim merged 28 commits intomasterfrom
Conversation
…de with and without defects Co-Authored-By: Mihail Olokin <45356788+nikololiahim@users.noreply.github.com>
…ethods into account
…x name of another case
…ological sort Also, created an opportunity to support cases with mutual recursion.
Implementation detects functions that are problematic and replaces bad calls with stubs
This reverts commit 13e4c57.
nikololiahim
approved these changes
May 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Defect description
The definition of the Liskov substitution principle is as follows:
We focus on one specific constraint that Liskov substitution principle enforces:
Example of the defect
In this example, the redefinition of method
fin thederivedobject changes the original input domain of argumentxfrom (-inf, 9) to (9, inf). This is a strengthening of the preconditions on methodf, which is a violation of the Liskov substitution principle.Documentation: https://hackmd.io/@_2BO8tPVRp6UE5c1RTpY-Q/rJZrkGNrc.