DN-8130: show md5 and sha1 in hunt result output#239
Merged
Conversation
Text formatter: add SHA1 and MD5 lines under SHA256 for both live_result and historical_result. Lines are only rendered when the fields are present so older API responses (or null hashes on URL artifacts) don't render bare 'SHA1: None' rows. Hash formatters: extend SHA1Output and MD5Output with historical_result / live_result methods mirroring SHA256Output, so '--output-format sha1' / 'md5' work uniformly across hunt results and artifact instances.
mjbradford89
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
live_resultandhistorical_result. Only rendered when the field is present, so older API responses or URL artifacts (null md5/sha1) don't print bare `SHA1: None` rows.Ticket: DN-8130.
Requires
All three PRs are forward-compatible at each layer: against older artifact-index, md5/sha1 stay null and the CLI skips the lines.
Test plan