prepared contextdeadline contribution #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move conn methods to conn.go * move stmt methods to stmt.go. * consolidate Prepare()
* remove internal re-prepare in subsequent calls to Exec/Query * move closeByRows to Rows.Close() * move closeByStmt to Stmt.Close() * use uber atomic library for better ergonomics
* queries will now be cancelled and the connections will be closed in the background if the context is canceled * supports setting transaction isolation level via BeginTx * Ping functionality supported * ResetSession now implemented to prevent driver from reusing bad connections * Moved most core functionality from non-context methods to context methods. Non-context methods call context methods with context.Background()
jpalawaga
changed the title
Member
Author
|
Original PR : alexbrainman/odbc#151 |
Member
Author
|
This was removed from mainline as it was causing panics. Additionally, a closer review of the code showed a lot of unfinished todos and other loose ends that should have been cleaned up before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ninthclowd provided a wonder contribution to the odbc project to support go context deadlines.
Reasons for this:
I'm taking the contribution at face value.