Minor invoke optimizations#256
Merged
namesty merged 8 commits intopolywrap:mainfrom Dec 19, 2023
MarcGuiselin:marc-opt
Merged
Conversation
MarcGuiselin
requested review from
cbrzn,
namesty and
nerfZael
as code owners
Contributor
Author
|
@namesty Anything stopping this from being merged? |
nerfZael
approved these changes
Dec 17, 2023
Contributor
Author
|
I made one more change, since I'd missed the fact that the buffers were not actually being written to. I've used |
namesty
approved these changes
Dec 19, 2023
Contributor
Nope, LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.