Fix: JavaScript minimization bug#1199
Merged
dOrgJelli merged 1 commit intoorigin-devfrom Aug 31, 2022
Merged
Conversation
krisbitney
requested review from
dOrgJelli,
namesty and
nerfZael
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client has a bug that prevents url resolvers from loading correctly after JavaScript minimization (aka "minification"). The bug can be circumvented by configuring weback to keep function names.
This PR fixes the issue so that webpack configuration is not necessary. It does so by removing the use of reflection from the client and uri resolvers. In particular, the client and uri resolvers were using
X.namewhere X is the name of a uri resolver class.I'm not sure how to write an automated test for this. I tested the fix using the Uniswap v3 front end. After linking the updated toolchain packages, the Uniswap v3 front end works without modifying the webpack configuration.
Closes #985.