Skip to content

feat: wrappers test cases removed from toolchain#1476

Merged
dOrgJelli merged 39 commits intoorigin-devfrom
feat/new-test-cases
Feb 18, 2023
Merged

feat: wrappers test cases removed from toolchain#1476
dOrgJelli merged 39 commits intoorigin-devfrom
feat/new-test-cases

Conversation

@cbrzn
Copy link
Copy Markdown
Contributor

@cbrzn cbrzn commented Jan 10, 2023

closes #1203

depends on: #1482 (& not required: #1480)

this pr has removed the packages/test-cases/cases/wrappers folder, and the tests have been migrated to the wasm test harness repository.

client tests have also been updated with a new structure to differentiate between different client features (open to any feedback)

development guidelines have also been updated. would appreciate strong feedback there to make sure that the development flow is clear enough when it comes to updating test cases

@cbrzn cbrzn marked this pull request as draft January 10, 2023 21:27
@cbrzn cbrzn force-pushed the feat/new-test-cases branch 6 times, most recently from 1dc48cb to 92b7979 Compare January 11, 2023 20:45
@cbrzn cbrzn force-pushed the feat/new-test-cases branch from 92b7979 to c325aa1 Compare January 11, 2023 20:52
@cbrzn cbrzn force-pushed the feat/new-test-cases branch from ff28a7a to 5b008af Compare January 25, 2023 14:48
@cbrzn cbrzn marked this pull request as ready for review January 27, 2023 11:56
@cbrzn cbrzn requested a review from pileks as a code owner January 27, 2023 11:56
Copy link
Copy Markdown
Contributor

@krisbitney krisbitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome. It's going to be a massive boost to testing speed and dev productivity!

Comment thread .github/workflows/generate-modified-test-wrappers.yaml
Comment thread package.json
Comment thread packages/js/client/src/__tests__/core/error-structure.spec.ts Outdated
Comment thread packages/test-cases/index.ts Outdated
Comment thread DEV_GUIDELINES.md Outdated
@cbrzn cbrzn requested a review from krisbitney February 6, 2023 16:02
krisbitney
krisbitney previously approved these changes Feb 7, 2023
Copy link
Copy Markdown
Contributor

@krisbitney krisbitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fantastic work

@dOrgJelli
Copy link
Copy Markdown
Contributor

@cbrzn added a fix here: polywrap/wrap-test-harness#39

@dOrgJelli dOrgJelli merged commit 5625a7a into origin-dev Feb 18, 2023
@dOrgJelli dOrgJelli deleted the feat/new-test-cases branch April 10, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-Wasm Test Harness

3 participants