CLI - Revert build command to --no-codegen instead of --codegen#1519
Merged
dOrgJelli merged 10 commits intoorigin-devfrom Feb 11, 2023
Merged
CLI - Revert build command to --no-codegen instead of --codegen#1519dOrgJelli merged 10 commits intoorigin-devfrom
build command to --no-codegen instead of --codegen#1519dOrgJelli merged 10 commits intoorigin-devfrom
Conversation
pileks
requested review from
Niraj-Kamdar,
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
…-build-revert-no-codegen
Contributor
|
What are the arguments for and against this? I kind of like the current state of things (requiring |
Contributor
|
@krisbitney you can check the conv here https://discord.com/channels/796821176743362611/1010304976406454323/1069951628943306805 |
Contributor
Okay, I see. Sounds good to me! |
Contributor
|
I'd be happy to approve this once tests are passing |
dOrgJelli
previously approved these changes
Feb 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked as Draft until we reach consensus regarding how the layout of these features should look like
Closes #1516
This PR reverts the
--codegenoption of thebuildcommand back to--no-codegen.Essentially, the
buildcommand will now runcodegenby default once again.Important caveat: The
-nshorthand for the--no-codegenoption has not been brought back. This is a personal style decision, please comment whether you agree. 😄