Skip to content

fix(cli): remove builder by default when build image strategy with buildx#1561

Merged
dOrgJelli merged 3 commits intoorigin-devfrom
nk/buildx-keep-builder
Feb 19, 2023
Merged

fix(cli): remove builder by default when build image strategy with buildx#1561
dOrgJelli merged 3 commits intoorigin-devfrom
nk/buildx-keep-builder

Conversation

@Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Feb 17, 2023

Changelog

Breaking Change:

  • Added new keepBuilder option which is default to false and removed the previous: removeBuilder option from the build manifest

Copy link
Contributor

@pileks pileks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dOrgJelli dOrgJelli merged commit bc40567 into origin-dev Feb 19, 2023
@dOrgJelli dOrgJelli deleted the nk/buildx-keep-builder branch April 10, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buildx docker container still running after build

3 participants